[Youtube] Add linked album for ytmusic searches #1208
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
added
enhancement
|
is this still in progress ? |
Author
|
Kind of, it has been a while so I have to see if the changes even work now. |
Author
|
I added a new method (getPlaylistId) to StreamInfoItem. This PR introduces an useful value for the playlistId only for youtube music searches which is the browseId. |
Author
|
A better idea might be to replace the playlistId with the url of the playlist? |
Stypox
requested changes
Oct 5, 2025
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Thank you! Sorry for not reviewing earlier, I somehow didn't notice this PR.
| } | ||
|
|
||
| @Override | ||
| public String getPlaylistId() throws ParsingException { |
Member
There was a problem hiding this comment.
This should be getPlaylistUrl() and return the playlist URL, rather than the ID, just like we have getUploaderUrl(). Also, you could also add getPlaylistName() since YouTube music seems to provide that information too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the linked album to the song when doing a ytmusic search. This is a draft and the current change is not visible. Some questions:
The browseId currently does nothing, hopefully I can try to get the browse endpoint working for ytmusic. I also plan to add a method to get the linked artist as well.